Set GCC version in all tools possibly parsing C code#6789
Merged
tautschnig merged 1 commit intodiffblue:developfrom May 17, 2022
Merged
Set GCC version in all tools possibly parsing C code#6789tautschnig merged 1 commit intodiffblue:developfrom
tautschnig merged 1 commit intodiffblue:developfrom
Conversation
The GCC version configures how our C lexer operates. Not setting it before running the C parser may cause spurious syntax errors, for example when parsing the system math headers. Tools that potentially link the built-in library will need to be able to parse those headers successfully.
tautschnig
force-pushed
the
bugfixes/set-gcc-version
branch
from
ec84223 to
b2b2734
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6789 +/- ##
===========================================
+ Coverage 76.90% 76.98% +0.07%
===========================================
Files 1590 1593 +3
Lines 183969 184121 +152
===========================================
+ Hits 141486 141740 +254
+ Misses 42483 42381 -102
Continue to review full report at Codecov.
|
TGWDB
approved these changes
Apr 11, 2022
Contributor
TGWDB
left a comment
TGWDB
left a comment
There was a problem hiding this comment.
A pity we still have to parse the same option in several places for different tools.
Collaborator
Author
Ack, and while it would be possible to have function to replace those 5 lines by just one function call, that function call would still be in slightly different places in each of the locations touched in this PR. |
peterschrammel
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GCC version configures how our C lexer operates. Not setting it
before running the C parser may cause spurious syntax errors, for
example when parsing the system math headers. Tools that potentially
link the built-in library will need to be able to parse those headers
successfully.